MINOR: [R] Add 25.0.1 NEWS entry - #50954

Nice!

@uros-b Hey there, I've seen you approving various PRs across different areas of the codebase. Just out of curiosity, what's the reason for this?

I have concerns that it could either a) cause confusion to new contributors who need their PRs reviewed by a committer and could mix up an approving review by a non-committer with an intention to merge by a committer, or b) lead to committers not reviewing/merging PRs as at first glance it looks like another committer has already reviewed it.

I don't think it's technically disallowed, but it's very unusual so I'm curious as to the reasoning.

Yes @thisisnic, I did review the PR here as I think it's a good contribution (hence the approval), but I wouldn't say that I'm trying to interfere or confuse anyone. Regarding a), github UI clearly separates committer and non-committer reviews, so I don't see the confusing part. As for b), committers already use the awaiting committer review label here, so I don't understand the confusion there either. Not sure why you would discourage my review on your PR, but thank you for taking the time to reply anyways!

Yes @thisisnic, I did review the PR here as I think it's a good contribution (hence the approval), but I wouldn't say that I'm trying to interfere or confuse anyone. Regarding a), github UI clearly separates committer and non-committer reviews, so I don't see the confusing part. As for b), committers already use the awaiting committer review label here, so I don't understand the confusion there either. Not sure why you would discourage my review on your PR, but thank you for taking the time to reply anyways!

I don't think you have malicious intent, but the reason I'm discouraging it is because it adds noise without any benefit, at a time where there's a lot of noise already from AI contributions etc, and increased pressure on maintainers to manage that.

I appreciate your interest in contributing though; happy to point you in the direction of places where it'd be helpful to have extra input if there was a specific area you're most interested in?

I have a different opinion. So I share my opinion here.

I think that (non-malicious) reviews from non committers are welcome. (For example, just posting AI generated meaningless reviews are not welcome.) Because:

• They will reduce maintainers' review costs.
• These non committers can learn about Apache Arrow and its community from these reviews.

Our "Becoming a committer" https://arrow.apache.org/committers/#becoming-committer also includes "reviewing other pull requests":

Contributions beyond pull requests, such as reviewing other pull requests, fixing bugs and documentation, triaging issues, answering community questions, improving usability, reducing technical debt, helping with CI, verifying releases, debugging in strange environments, etc.

How about mentioning any committer when you approve a PR? We may be able to merge PRs faster.

BTW, I think that Nic's this point is a good suggestion too.

happy to point you in the direction of places where it'd be helpful to have extra input if there was a specific area you're most interested in?